Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update directory tree of output segments from VoD pipeline #133

Merged
merged 3 commits into from
Nov 3, 2022
Merged

Update directory tree of output segments from VoD pipeline #133

merged 3 commits into from
Nov 3, 2022

Conversation

emranemran
Copy link
Collaborator

@emranemran emranemran commented Nov 2, 2022 •
edited
Loading

Fix #134

@emranemran emranemran requested review from AlexKordic, thomshutt and victorges and removed request for AlexKordic and thomshutt November 2, 2022 04:47
@emranemran
Copy link
Collaborator Author

emranemran commented Nov 2, 2022 •
edited
Loading

TODOs before merging:

  • Fix failing tests
  • Double check re-use of any unnecessary variables introduced in path/url manipulation
  • And these suggestions from @victorges:
    • Update rendition folder names to use profile names instead (example 360p/ instead of rendition-1/
    • Update profile list to use 240p, 480p, 720p

@emranemran emranemran mentioned this pull request Nov 2, 2022
Closed
thomshutt
thomshutt approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@thomshutt thomshutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the changes you mentioned

@emranemran emranemran force-pushed the emran/revamp-dir-structure-of-outputs-1 branch from b2015c4 to 6a95bfd Compare November 2, 2022 22:26
@emranemran emranemran added enhancement New feature or request and removed enhancement New feature or request labels Nov 3, 2022
@emranemran
transcode/segmenting: update output directory tree structure of segments
3ec0322 
The new  directory structure of the outputs from segmentation and
transcoding steps are as follows in the root output directory specified
in the request:

  index.m3u8
  rendition-0/
      |----index.m3u8
      |----*.ts
  rendition-1/
      |----index.m3u8
      |----*.ts
  source/
      |----index.m3u8
      |----*.ts
@emranemran emranemran force-pushed the emran/revamp-dir-structure-of-outputs-1 branch from 6a95bfd to a8538eb Compare November 3, 2022 01:32
@emranemran emranemran force-pushed the emran/revamp-dir-structure-of-outputs-1 branch 3 times, most recently from 806eb59 to b2e7fba Compare November 3, 2022 05:14
@emranemran emranemran force-pushed the emran/revamp-dir-structure-of-outputs-1 branch from b2e7fba to 03d8d5d Compare November 3, 2022 05:17
@emranemran emranemran merged commit 1a11038 into main Nov 3, 2022
@emranemran
Copy link
Collaborator Author

These changes are being handled in a follow-up PR as it required refactor of larger parts for code readability:

  • Update rendition folder names to use profile names instead (example 360p/ instead of rendition-1/
  • Update profile list to use 240p, 480p, 720p

iameli pushed a commit that referenced this pull request Feb 7, 2023
@github-actions @livepeer-docker
[AUTO-COMMIT] Update manifest.yaml (#133)
acefdb6 
Files changed:\nM	manifest.yaml

Co-authored-by: livepeer-docker <[email protected]>
@hjpotter92 hjpotter92 deleted the emran/revamp-dir-structure-of-outputs-1 branch May 30, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomshutt thomshutt thomshutt approved these changes

@AlexKordic AlexKordic Awaiting requested review from AlexKordic

@victorges victorges Awaiting requested review from victorges

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update directory tree structure of segments in VoD pipeline
2 participants
@emranemran @thomshutt